-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal: support Reservation preemption #1887
proposal: support Reservation preemption #1887
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1887 +/- ##
==========================================
+ Coverage 67.27% 67.55% +0.28%
==========================================
Files 411 413 +2
Lines 45875 46229 +354
==========================================
+ Hits 30863 31231 +368
+ Misses 12775 12730 -45
- Partials 2237 2268 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3fefae6
to
e4ce32f
Compare
docs/proposals/scheduling/20240201-enbale-reservation-preempt.md
Outdated
Show resolved
Hide resolved
docs/proposals/scheduling/20240201-enbale-reservation-preempt.md
Outdated
Show resolved
Hide resolved
docs/proposals/scheduling/20240201-enbale-reservation-preempt.md
Outdated
Show resolved
Hide resolved
docs/proposals/scheduling/20240201-enbale-reservation-preempt.md
Outdated
Show resolved
Hide resolved
docs/proposals/scheduling/20240201-enbale-reservation-preempt.md
Outdated
Show resolved
Hide resolved
docs/proposals/scheduling/20240201-enbale-reservation-preempt.md
Outdated
Show resolved
Hide resolved
docs/proposals/scheduling/20240201-enbale-reservation-preempt.md
Outdated
Show resolved
Hide resolved
docs/proposals/scheduling/20240201-enbale-reservation-preempt.md
Outdated
Show resolved
Hide resolved
c68d885
to
1da6003
Compare
docs/proposals/scheduling/20240201-enbale-reservation-preempt.md
Outdated
Show resolved
Hide resolved
docs/proposals/scheduling/20240201-enbale-reservation-preempt.md
Outdated
Show resolved
Hide resolved
1da6003
to
bb5c682
Compare
docs/proposals/scheduling/20240201-enbale-reservation-preempt.md
Outdated
Show resolved
Hide resolved
bb5c682
to
b49b1c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
b49b1c9
to
a96f325
Compare
docs/proposals/scheduling/20240201-enbale-reservation-preempt.md
Outdated
Show resolved
Hide resolved
docs/proposals/scheduling/20240201-enbale-reservation-preempt.md
Outdated
Show resolved
Hide resolved
766aa7b
to
e8da9bc
Compare
/lgtm |
@buptcozy Do you have any further comments about the KEP? |
Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
e8da9bc
to
3531661
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com> Co-authored-by: xulinfei.xlf <xulinfei.xlf@alibaba-inc.com>
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Design for #1856
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test